[ https://issues.apache.org/jira/browse/IGNITE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278290#comment-16278290 ]
Alexey Kuznetsov edited comment on IGNITE-6846 at 12/6/17 2:45 PM: ------------------------------------------------------------------- [~vkulichenko] Only primary and backups. I have 2 questions left, could you please answer them: 11) getEntryProcessorHits() - Hit number - number of total entry processor invocations happened on keys exsisting in cache. While Mises number - number of invocations on keys not existing in cache. Am i right ? 12) Don't you mind if i create a separate ticket(current ticket sub-task) for the following metrics(motivation below) ? {code:java} getMinEntryProcessorReadOnlyInvocationTime(); getAverageEntryProcessorReadOnlyInvocationTime(); getMaxEntryProcessorReadOnlyInvocationTime(); {code} _Motivation :_ too much new complicated code needed. _How time calculations work_ : we start invoke by sending certain request to primary node and waiting for response.When response is received we must calculate time. _Problem, faced when implementing 'read-only invoke time' metrics:_ response message contains no information about whether it was 'read-only' or 'update'\'remove' operation. As a result we cannot decide whether we should increment 'read-only' or 'update'\'remove' metric. _Solution to problem:_ alter message, add field indicating transform operation was performed. was (Author: alexey kuznetsov): [~vkulichenko] Only primary and backups. I have 2 questions left, could you please answer them: 11) getEntryProcessorHits() - Hit number - number of total entry processor invocations happened on keys exsisting in cache. While Mises number - number of invocations on keys not existing in cache. Am i right ? 12) Don't you mind if i create a separate ticket for the following metrics(motivation below) ? {code:java} getMinEntryProcessorReadOnlyInvocationTime(); getAverageEntryProcessorReadOnlyInvocationTime(); getMaxEntryProcessorReadOnlyInvocationTime(); {code} _Motivation :_ too much new complicated code needed. _How time calculations work_ : we start invoke by sending certain request to primary node and waiting for response.When response is received we must calculate time. _Problem, faced when implementing 'read-only invoke time' metrics:_ response message contains no information about whether it was 'read-only' or 'update'\'remove' operation. As a result we cannot decide whether we should increment 'read-only' or 'update'\'remove' metric. _Solution to problem:_ alter message, add field indicating transform operation was performed. > Add metrics for entry processor invocations > ------------------------------------------- > > Key: IGNITE-6846 > URL: https://issues.apache.org/jira/browse/IGNITE-6846 > Project: Ignite > Issue Type: Improvement > Components: cache > Affects Versions: 2.3 > Reporter: Valentin Kulichenko > Assignee: Alexey Kuznetsov > Priority: Critical > Labels: iep-6 > Fix For: 2.4 > > > {{CacheMetrics}} object has multiple metrics for various cache operations > like {{get}}, {{put}} and {{remove}}, but nothing for > {{invoke}}/{{EntryProcessor}}. It makes sense to add such metrics, for > example: > * Total number of `invoke` operations executed. > * Number of `invoke` operations that included updates. > * Number of read-only `invoke` operations. > * Min/max/avg execution time. > * ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)