[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287363#comment-16287363
]
Alexander Paschenko commented on IGNITE-4750:
---------------------------------------------
[~tledkov-gridgain], my comments:
{{GridSqlAggregateFunction}}:
1. Please don't use strings addition together with {{StatementBuilder}} - use
{{append}} instead.
2. Please use {{resetCount()}} before {{appendExceptFirst()}} - these
operations are looking at the same counter, and therefore it should be reset
every time you use {{appendExceptFirst()}}.
3. Methods {{setGroupConcat*}} have way too wordy param names, like this:
{{setGroupConcatSeparator(groupConcatSeparator)}} - there's redundancy, you can
use simply {{separator}} for param name without losing any clarity.
4. {{GridSqlQueryParser}}: Code conventions are violated - long lines.
{{GridSqlQuerySplitter}}:
5. Please throw {{IgniteSqlException}} instead of {{IgniteException}}, error
code should be {{UNSUPPORTED_OPERATION}}.
6. Here: {{rdcAgg = aggregate(false, agg.type())}} please use {{GROUP_CONCAT}}
as the second arg for clarity.
7. {{GridSqlType}}: I believe SQL keyword for strings is {{VARCHAR}}, not
{{STRING}}, isn't it?
8. {{IgniteSqlGroupConcatCollocatedTest}}: please fix long lines.
> SQL: Support GROUP_CONCAT function
> ----------------------------------
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Denis Magda
> Assignee: Taras Ledkov
> Fix For: 2.4
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
