[
https://issues.apache.org/jira/browse/IGNITE-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304760#comment-16304760
]
Vladimir Ozerov commented on IGNITE-6022:
-----------------------------------------
[~rkondakov], my comments:
1) {{DmlStatementsProcessor.processDmlSelectResultBatched}} - we should never
reach this method in case of MERGE. Please make sure we have tests for this.
2) {{DmlBatchSender}} - could you please explain the meaning of these changes?
I think we do not need any maps or so - array should be enough. Also, it is not
efficient to flush *all* batches if duplicate in *one* of them is found.
3) {{DmlBatchSender.perRowUpdateCounter}} - unused method
4) We need to extend test coverage for batched operations - use different types
(INSERT, UPDATE, MERGE, DELETE), add multiple operations in a batch, simulate
errors in the middle of the batch and make sure returned results conform to
JDBC specification.
> SQL: add native batch execution support for DML statements
> ----------------------------------------------------------
>
> Key: IGNITE-6022
> URL: https://issues.apache.org/jira/browse/IGNITE-6022
> Project: Ignite
> Issue Type: Task
> Components: sql
> Affects Versions: 2.1
> Reporter: Vladimir Ozerov
> Assignee: Roman Kondakov
> Labels: iep-1, performance
> Fix For: 2.4
>
>
> We have batch execution support for JDBC and ODBC drivers. This decreases
> number of network hops. However, we do not have any batch execution support
> on the server side. It means that for batch of N similar statements, every
> statement will go through the whole execution chain - parsing, splitting,
> communication with servers. And while parsing and splitting might be avoided
> with help of statement cache, the most heavy part - network communication -
> is still there.
> We need to investigate how to optimize the flow for batch updates. Possible
> improvements:
> 1) Execute statements with certain degree of parallelism;
> 2) Send several query execution requests to the server at once;
> 3) Ensure that caches are used properly for batching - we should not parse
> the same request multiple times.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
