[
https://issues.apache.org/jira/browse/IGNITE-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305399#comment-16305399
]
Sergey Kalashnikov edited comment on IGNITE-5949 at 12/28/17 12:27 PM:
-----------------------------------------------------------------------
Fixed.
1) I have added the checks to the {{prepareChangeOnNotStartedCache()}} and
{{prepareChangeOnStartedCache()}} where other similar checks are made.
2) There are tests that check for proper error messages.
JDBC column metadata is also checked in the new tests with the help of
{{checkTableState()}} and {{getColumnMeta()}} routines.
TC test results seem to be OK.
[~vozerov], Please take a look.
was (Author: skalashnikov):
Fixed.
1) I have added the checks to the {{prepareChangeOnNotStartedCache()}} and
{{prepareChangeOnStartedCache()}} where other similar checks are made.
2) There are tests that check for proper error messages.
JDBC column metadata is also checked in the new tests with the help of
{{checkTableState()}} and {{getColumnMeta()}} routines.
TC test results seem to be OK.
> DDL: Support ALTER TABLE DROP COLUMN
> ------------------------------------
>
> Key: IGNITE-5949
> URL: https://issues.apache.org/jira/browse/IGNITE-5949
> Project: Ignite
> Issue Type: New Feature
> Components: sql
> Reporter: Andrew Mashenkov
> Assignee: Sergey Kalashnikov
> Labels: important
> Fix For: 2.4
>
>
> Ignite should support {{DROP COLUMN}} operation for {{ALTER TABLE}} command.
> Design considerations:
> 1) Drop should only be possible on binary types without schema (see
> IGNITE-6611). Probably we will need a new option for {{CREATE TABLE}} command
> 2) Drop should not block other operations for a long time. We should
> synchronously block the table, change meta, then release the lock and let
> operations continue.
> 3) Actual data remove should be performed asynchronously in the same way we
> create index. During this time we should not allow any other modifications to
> the table
> 4) Be careful with node stop - we do not want to wait for years for this
> command to complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
