[
https://issues.apache.org/jira/browse/IGNITE-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320539#comment-16320539
]
Andrey Gura commented on IGNITE-7050:
-------------------------------------
[~mcherkasov] I've looked at your changes and have a few comments:
#. {{SpringCache}} constructor have argument of {{SpringCacheManager}} type and
this argument will be assigned to the instance field and never used. Why? Also
could you please remove unused imports and non-public methods and add valuable
javadoc to class fields and methods?
#. It seems that {{GridSpringCacheManagerMultiJvmSelfTest}} class should
contain some tests or should be removed.
#. {{GridResourceTestUtils}} and {{TestClosure}} classes are unused.
#. {{README.txt}} file should stress that this module exists in order to
support Spring *3*.
Could you please this comments?
[~avinogradov] Please help with review of maven related issues.
> Add support for spring3
> -----------------------
>
> Key: IGNITE-7050
> URL: https://issues.apache.org/jira/browse/IGNITE-7050
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Mikhail Cherkasov
> Assignee: Mikhail Cherkasov
> Fix For: 2.4
>
>
> there are still users who use spring3 and hence can't use ignite which
> depends on spring4. I think we can create separate modules for spring3
> support, like it was done for hibernate 4/5.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
