[ 
https://issues.apache.org/jira/browse/IGNITE-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321942#comment-16321942
 ] 

Pavel Tupitsyn commented on IGNITE-6456:
----------------------------------------

[~rkondakov] I see some issues with {{onHandshake}} method:
* Duplicate response writing code.
* Incorrect {{clientType}} check. We should return an error immediately if 
{{clientType}} is not valid.

Let's refactor and fix these.

> Add flags to ClientConnectorConfiguration which enable/disable different 
> clients
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-6456
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6456
>             Project: Ignite
>          Issue Type: Improvement
>          Components: jdbc, odbc, thin client
>    Affects Versions: 2.1
>            Reporter: Igor Sapego
>            Assignee: Roman Kondakov
>              Labels: usability
>             Fix For: 2.4
>
>
> There is currently no way to disable only one client. For example, currently 
> you can't disallow thin JDBC driver connectivity alone, you can only disable 
> the whole {{ClientListenerProcessor}}, which is going to disable ODBC and 
> thin .NET clients as well.
> We should add options to disable/enable every single client, supported by the 
> {{ClientListenerProcessor}} separately. For example, we can add flags to the 
> {{ClientConnectorConfiguration}}:
> {{allowJdbc}}
> {{allowOdbc}}
> {{allowClient}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to