[ https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330900#comment-16330900 ]
Oleg Ignatenko edited comment on IGNITE-7454 at 1/18/18 8:21 PM: ----------------------------------------------------------------- Confirmed above observation from [~vveider]: "incorrect" package indeed doesn't break the compilation. I just tested this by creating a trial class in some code I worked with injected artificial package name that didn't match containing directory: build with {{mvn clean package}} passed successfully. ^^^ [~avinogradov] - you might be interested in this as we yesterday discussed this issue. You may even try similar test with your own code - it turned out very easy to make and try and see for yourself. ----- As a side note Java 8 JLS uses appropriate example in [section 7.2. Host Support for Packages|https://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.2] with package name {{children.activities.crafts.papierMâché}} explicitly differing from source code directory {{children/activities/crafts/papierM@00e2ch@00e9}} (concrete purpose of the example in JLS is to demonstrate options for supporting Unicode in package names but it also shows that generally this difference is not forbidden). was (Author: oignatenko): Confirmed above observation from [~vveider]: "incorrect" package indeed doesn't break the compilation. I just tested this by creating a trial class in some code I worked with injected artificial package name that didn't match containing directory: build with {{mvn clean package}} passed successfully. ^^^ [~avinogradov] - you might be interested in this as we yesterday discussed this issue. You may even try similar test with your own code - it turned out very easy to make and try and see for yourself. > Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203 > ----------------------------------------------------------------------------- > > Key: IGNITE-7454 > URL: https://issues.apache.org/jira/browse/IGNITE-7454 > Project: Ignite > Issue Type: Bug > Components: examples, ml, yardstick > Reporter: Oleg Ignatenko > Assignee: Oleg Ignatenko > Priority: Major > Fix For: 2.4 > > > Wrong package in IgniteExamplesMLTestSuite after it was moved per > IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to > the list in {{IgniteExamplesSelfTestSuite{{}}}} which is supposed to run all > examples self-tests. > Change to correct package: \{{org.apache.ignite.testsuites}} and add to main > testsuite. > For the sake of completeness, a bunch of newer ml benchmarks (done per > IGNITE-7214 and IGNITE-7097) were forgotten to be moved in yardstick module > when merging to master. These should be fixed (moved to proper folder). -- This message was sent by Atlassian JIRA (v7.6.3#76005)