[
https://issues.apache.org/jira/browse/IGNITE-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334372#comment-16334372
]
Oleg Ignatenko commented on IGNITE-6899:
----------------------------------------
I pulled the recent changes and rerun unit tests in GAGridTestSuite and
modified example (with non-default elitism count) - everything is OK. I also
reviewed recent changes made to javadocs - as far as I can tell most issues
were corrected.
To make sure that nothing critical is missed I plan to run [automated check for
licenses and javadocs on
TeamCity|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_LicensesJavadoc]
(plan to update this comment with check results).
All of my prior review comments appear to be addressed, including those about
docs at readme.io. Speaking of enum {{SELECTION_METHOD}}, please disregard my
comments from previous review round: upon a closer inspection it looks good
enough as is to me. Back then I also recommended a second round design review -
I asked [~chief] and he promised to take a look.
> Adding GA Grid to Apache Ignite ML module.
> ------------------------------------------
>
> Key: IGNITE-6899
> URL: https://issues.apache.org/jira/browse/IGNITE-6899
> Project: Ignite
> Issue Type: New Feature
> Components: ml
> Reporter: Yury Babak
> Assignee: Turik Campbell
> Priority: Major
> Fix For: 2.5
>
> Attachments: coverage.zip
>
>
> We want to add GA Grid to our ML Module.
> This is the first iteration of this integration. On this step we will simple
> add GA Grid to the separate package in ML module.
> (i) This is a good package for GA Grid: org.apache.ignite.ml.genetic
> (i) For GA Grid we need unit tests as well as examples
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
