[ 
https://issues.apache.org/jira/browse/IGNITE-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347392#comment-16347392
 ] 

Denis Magda commented on IGNITE-7532:
-------------------------------------

[~zaleslaw] , I did a general review. There are some of the points that need 
your attention/assistance:
 * k-NN classification doc says - _trainingSet dataset loaded that might be 
taken from Iris datasets._ Please provide a link to the Iris datasets you're 
talking about.
 * This paragraph of k-NN regression doesn't make sense to me:

_Also, k-NN regression's output is a property value for the object. This value 
is an average of the values of its k nearest neighbors. If `k` is `1`, then the 
object is simply assigned to the property value of that single nearest 
neighbor._

What is an object? What's a property value? Please refer to other ML 
documentations (Spark and others) so that I can grasp why you're trying to 
explain. Alternatively, you can write down a Russian version of the paragraph 
and I'll translate it to English.
 * k-NN regression says - _`_trainingSet_` dataset that might be loaded from 
the machine.names dataset._ What's the machine.names dataset? We need to paste 
the reference. Make sure all these properly documented in the examples.

> kNN Documentation
> -----------------
>
>                 Key: IGNITE-7532
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7532
>             Project: Ignite
>          Issue Type: Task
>          Components: documentation, ml
>            Reporter: Aleksey Zinoviev
>            Assignee: Denis Magda
>            Priority: Major
>              Labels: documentaion
>             Fix For: 2.4
>
>
> We want to add kNN Regression and Classification docs



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to