[ 
https://issues.apache.org/jira/browse/IGNITE-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349185#comment-16349185
 ] 

Valentin Kulichenko commented on IGNITE-7337:
---------------------------------------------

[~NIzhikov], let's remove {{OPTION_WRITE_PARTITIONS_NUM}}. One can always call 
{{coalesce}} on original data frame explicitly if needed, right?

Also minor comment regarding implementation. When using private API, it's 
better to cast {{Ignite}} to {{IgniteEx}} interface rather than 
{{IgniteKernal}}. This interface designed specifically for such cases.

Please make these changes and I will do the final review.

> Spark Data Frames: support saving a data frame in Ignite
> --------------------------------------------------------
>
>                 Key: IGNITE-7337
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7337
>             Project: Ignite
>          Issue Type: New Feature
>          Components: spark
>    Affects Versions: 2.3
>            Reporter: Valentin Kulichenko
>            Assignee: Nikolay Izhikov
>            Priority: Major
>             Fix For: 2.5
>
>
> Once Ignite data source for Spark is implemented, we need to add an ability 
> to store a data frame in Ignite. Most likely if should be enough to provide 
> implementation for the following traits:
> * {{InsertableRelation}}
> * {{CreatableRelationProvider}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to