[ 
https://issues.apache.org/jira/browse/IGNITE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350364#comment-16350364
 ] 

ASF GitHub Bot commented on IGNITE-7508:
----------------------------------------

GitHub user AMashenkov opened a pull request:

    https://github.com/apache/ignite/pull/3468

    IGNITE-7508: Fix contention on system property access in 
GridKernalContextImpl::isDaemon()

    Fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-7508

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3468
    
----
commit a78297bf6a531bf5b1d7764637a31542c029c754
Author: Andrey V. Mashenkov <andrey.mashenkov@...>
Date:   2018-02-02T13:57:05Z

    IGNITE-7508: Fix contention on system property access in 
GridKernalContextImpl::isDaemon().

----


> GridKernalContextImpl::isDaemon creates contention on system properties access
> ------------------------------------------------------------------------------
>
>                 Key: IGNITE-7508
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7508
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Stanislav Lukyanov
>            Assignee: Andrew Mashenkov
>            Priority: Major
>
> GridKernalContextImpl::isDaemon reads system property IGNITE_DAEMON on every 
> call, leading to contention on the system properties lock. The lock is shown 
> as contended in the Java Mission Control analysis of a JFR recording of the 
> IgnitePutGetBenchmark.
> The fix would be to cache IGNITE_DAEMON value (e.g. in IgniteUtils) since it 
> isn't supposed to be changed during the JVM's lifetime anyway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to