Anton Dmitriev edited comment on IGNITE-7660 at 2/13/18 6:39 PM:

I've updated the description, please take a look.

was (Author: dmitrievanthony):
I've updated description, please take a look.

> Refactor LSQR algorithm
> -----------------------
>                 Key: IGNITE-7660
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7660
>             Project: Ignite
>          Issue Type: Improvement
>          Components: ml
>            Reporter: Anton Dmitriev
>            Priority: Minor
> This issues is the nest step of the IGNITE-7438 task.
> In the IGNITE-7438 the AbstractLSQR implementation has been copied from the 
> SciPy implementation which has been copies from another old implementation. 
> As result the code in the 
> [AbstractLSQR|https://github.com/apache/ignite/blob/master/modules/ml/src/main/java/org/apache/ignite/ml/math/isolve/lsqr/AbstractLSQR.java]
>  looks a bit weird. All variables have meaningless names and the whole 
> algorithm written as the one method.
> The goal of this task is to refactor the LSQR code and:
>  * Make variable names more meaningful.
>  * Add comments to the variables and result (see 
> [LSQRResult|https://github.com/apache/ignite/blob/master/modules/ml/src/main/java/org/apache/ignite/ml/math/isolve/lsqr/LSQRResult.java]).
>  * Move parts of the algorithm into separate methods where it's appropriate.

This message was sent by Atlassian JIRA

Reply via email to