[ 
https://issues.apache.org/jira/browse/IGNITE-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372565#comment-16372565
 ] 

Alexey Goncharuk commented on IGNITE-7749:
------------------------------------------

Pavel, changes look good to me. Merged to master.

> testDiscoCacheReuseOnNodeJoin fails on TC
> -----------------------------------------
>
>                 Key: IGNITE-7749
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7749
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.5
>            Reporter: Pavel Kovalenko
>            Assignee: Alexey Goncharuk
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.5
>
>
> {code:java}
> java.lang.ClassCastException: 
> org.apache.ignite.internal.util.GridConcurrentHashSet cannot be cast to 
> java.lang.String
>     at 
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.assertDiscoCacheReuse(IgniteDiscoveryCacheReuseSelfTest.java:93)
>     at 
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.testDiscoCacheReuseOnNodeJoin(IgniteDiscoveryCacheReuseSelfTest.java:64)
> {code}
> There are 2 problems in the test.
> 1) We don't wait for final topology version is set on all nodes and start 
> checking discovery caches immediately after grids starting. It leads to 
> possible NullPointerException while accessing to discovery caches history.
> 2) We don't use explicit assertEquals(String, Object, Object) related to 
> comparing Objects, while Java can choose assertEquals(String, String) method 
> to compare discovery cache fields which we're getting in runtime using 
> reflection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to