Denis Magda commented on IGNITE-7655:

[~NIzhikov] , please clarify the following questions.
 # You're saying "the data frame will be appended to the existing table. 
Existing table data will not be changed.". What does appending mean here? As 
far as I understand, you're just going to *insert* new data ignoring the data 
which keys are already in the table.
 # which mode is a default? 
 # Is there a mode that updates existing rows, inserts new from the data frame 
and does NOT delete the rows that were in the table initially?
 # How do I set a mode? You start talking about the data frames right away but 
do not explain how to use them.
 # You say "Note, internally all inserts are done through IgniteDataStreamer. 
Several optional parameters exists to configure internal streamer. Please, see 
full list of available options.". I would start "Saving Data Frame" section 
with the explanation of how all this works. From what I see, we're going to use 
CREATE TABLE to create a table and then store data in Ignite with the streamer, 
right? Please elaborate more on this in the doc.

[~abchaudhri], could you please finalize the review after [~NIzhikov] addresses 
the notes above? Please feel free to work together to make this doc exceptional 
and easy to follow!

> Spark Data Frames: saving data frames into Ignite needs to be documented
> ------------------------------------------------------------------------
>                 Key: IGNITE-7655
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7655
>             Project: Ignite
>          Issue Type: Bug
>          Components: documentation, spark
>            Reporter: Nikolay Izhikov
>            Assignee: Denis Magda
>            Priority: Major
>             Fix For: 2.4
> Once IGNITE-7337 is ready for merge.
> This new feature of Ignite needs to be documented.

This message was sent by Atlassian JIRA

Reply via email to