[
https://issues.apache.org/jira/browse/IGNITE-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376626#comment-16376626
]
Alexander Menshikov commented on IGNITE-7640:
---------------------------------------------
*[~agoncharuk]*
*Done. Please review.*
*Details:*
1) I removed field _DiscoveryDataClusterState.transitionError_ because there is
no place in the project where setter was called, so it always was null.
2) Replaced _DiscoveryDataClusterState.transitionRes_ with
_DiscoveryDataClusterState.transitionFut_ to avoid concurrent passing result
from _GridClusterStateProcessor#onStateFinishMessage_ to
_GridClusterStateProcessor#publicApiActiveState_ . It also allows me to remove
_GridClusterStateProcessor.transitionFuts_. See details in code.
3) Optimized _DiscoveryDataClusterState#setTransitionResult_ using because in
all cases except one we don't need comparison of request id. See details in
code.
> Refactor DiscoveryDataClusterState to be immutable
> --------------------------------------------------
>
> Key: IGNITE-7640
> URL: https://issues.apache.org/jira/browse/IGNITE-7640
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Affects Versions: 2.4
> Reporter: Alexey Goncharuk
> Assignee: Alexander Menshikov
> Priority: Major
> Fix For: 2.5
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)