[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404624#comment-16404624
 ] 

Pavel Konstantinov edited comment on IGNITE-7864 at 3/19/18 11:15 AM:
----------------------------------------------------------------------

# NPE in case when executed --baseline 
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Error: java.lang.NullPointerException
{code}
# please use the same style of warning
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline version 1
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning! This command will perform changes in baseline!
{code}
{code}
PS C:\work\ignite-7864\bin> .\control.bat --deactivate
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning: the command will deactivate a cluster.
{code}
# detection of '--force' need to be reworked
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline remove --force 
ba5afe6e-5a3b-4238-8492-ac577d004112
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning! This command will perform changes in baseline!
Press 'y' to continue...
{code}
# '--force' option is not documented 


was (Author: pkonstantinov):
# NPE in case when executed --baseline 
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Error: java.lang.NullPointerException
{code}
# please use the same style of warning
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline version 1
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning! This command will perform changes in baseline!
{code}
{code}
PS C:\work\ignite-7864\bin> .\control.bat --deactivate
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning: the command will deactivate a cluster.
{code}
# detection of '--force' need to be reworked
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline remove --force 
ba5afe6e-5a3b-4238-8492-ac577d004112
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1
--------------------------------------------------------------------------------
Warning! This command will perform changes in baseline!
Press 'y' to continue...
{code}

> Control utility: Add confirm on dangerous operations
> ----------------------------------------------------
>
>                 Key: IGNITE-7864
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7864
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Kuznetsov
>            Assignee: Pavel Konstantinov
>            Priority: Major
>             Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to