[ 
https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417052#comment-16417052
 ] 

Ryabov Dmitrii edited comment on IGNITE-6879 at 3/28/18 8:59 AM:
-----------------------------------------------------------------

Javadoc is broken [1] "IgniteRepository.java:50: warning - Tag @link: can't 
find save(Iterable) in org.springframework.data.repository.CrudRepository"

Also check {{JdbcThinConnectionSSLTest.testDefaultContext()}} [2], because it 
failed only in your PR. I'm not sure that it is your bad, if this fail is not 
by your changes I recommend you to merge master into your PR branch again

[1] 
https://ci.ignite.apache.org/viewLog.html?buildId=1163086&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Javadoc
[2] 
https://ci.ignite.apache.org/viewLog.html?buildId=1163057&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteJdbcDriver


was (Author: somefire):
Javadoc is broken [1] "IgniteRepository.java:50: warning - Tag @link: can't 
find save(Iterable) in org.springframework.data.repository.CrudRepository"

Also check `JdbcThinConnectionSSLTest.testDefaultContext()` [2], because it 
failed only in your PR. I'm not sure that it is your bad, if this fail is not 
by your changes I recommend you to merge master into your PR branch again

[1] 
https://ci.ignite.apache.org/viewLog.html?buildId=1163086&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Javadoc
[2] 
https://ci.ignite.apache.org/viewLog.html?buildId=1163057&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteJdbcDriver

> Support Spring 2.0
> ------------------
>
>                 Key: IGNITE-6879
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6879
>             Project: Ignite
>          Issue Type: Improvement
>          Components: spring
>    Affects Versions: 2.3
>            Reporter: Alexey Kukushkin
>            Assignee: Roman Meerson
>            Priority: Major
>
> Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt 
> with Spring 2.0. Trying to change the Spring dependency version to 
> 2.0.0.release results in compile errors like below and requires regression in 
> general. 
> This improvement was created to either migrate from Spring 1.1 to 2.0 or 
> create another set of modules ignite-spring-xxx-2 to have backward 
> compatibility with Spring 1.1.
> [ERROR] 
> /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10]
>  name clash: deleteAll(java.lang.Iterable<ID>) in 
> org.apache.ignite.springdata.repository.IgniteRepository and 
> deleteAll(java.lang.Iterable<? extends T>) in 
> org.springframework.data.repository.CrudRepository have the same erasure, yet 
> neither overrides the other



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to