Dmitriy Pavlov commented on IGNITE-5874:

I left several minor proposals in CR.

Change looks good to me provided that we will cover crash recovery from new 
PageSnapshot records by unit or integration tests.

[~agoncharuk], could you also take a look to change?

> Store TTL expire times in B+ tree on per-partition basis
> --------------------------------------------------------
>                 Key: IGNITE-5874
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5874
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache, persistence
>    Affects Versions: 2.1
>            Reporter: Ivan Rakov
>            Assignee: Andrew Mashenkov
>            Priority: Major
>             Fix For: 2.5
>         Attachments: IgnitePdsWithTtlTest.java
> TTL expire times for entries are stored in PendingEntriesTree, which is 
> singleton for cache. When expiration occurs, all system threads iterate 
> through the tree in order to remove expired entries. Iterating through single 
> tree causes contention and perfomance loss. 
> Related performance issue: https://issues.apache.org/jira/browse/IGNITE-5793
> We should keep instance of PendingEntriesTree for each partition, like we do 
> for CacheDataTree.

This message was sent by Atlassian JIRA

Reply via email to