[ 
https://issues.apache.org/jira/browse/IGNITE-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441025#comment-16441025
 ] 

Dmitriy Pavlov commented on IGNITE-7786:
----------------------------------------

Thank, I've looked to these changes and I can suggest improving javadoc, 
probably all methods and fields may have javadoc like
{code:java}
@param pingInterval See {@link GridClientConfiguration#PING_INTERVAL}.{code}

It is not too hard to implement and allowed other Igniters to easily serf in 
code base avoiding question like where this field is used.

> Changing baseline topology on cluster may have error in control.sh utility
> --------------------------------------------------------------------------
>
>                 Key: IGNITE-7786
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7786
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Dmitry Sherstobitov
>            Assignee: Ivan Daschinskiy
>            Priority: Major
>
> Looks like there is hardcoded timeout for waiting result of change baseline 
> operation
> In cluster there is following behaviour: 
>  # Set new baseline topology version
>  # Utility starts, but then fails by connection error
>  # Cluster successfully activated
> {code:java}
> ...Start node...
> ...Waiting for topology snapshot...
> > control_utility.sh --baseline version 9
> Control utility 
> 2017 Copyright(C) Apache Software Foundation
> User: test
> --------------------------------------------------------------------------------
> Failed to set baseline with specified topology version.
> Connection to cluster failed.
> Error: Failed to perform request (connection failed): /IP
> ...few milliseconds later...
> > control_utility.sh --baseline version 9
> Control utility 
> 2017 Copyright(C) Apache Software Foundation
> User: test
> --------------------------------------------------------------------------------
> Cluster state: active
> Current topology version: 9
> Baseline nodes:
> ConsistentID=node1, STATE=ONLINE
> ConsistentID=node10001, STATE=ONLINE
> ConsistentID=node2, STATE=ONLINE
> ConsistentID=node3, STATE=ONLINE
> ConsistentID=node4, STATE=ONLINE
> --------------------------------------------------------------------------------
> Number of baseline nodes: 5
> Other nodes not found.{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to