[
https://issues.apache.org/jira/browse/IGNITE-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443782#comment-16443782
]
Vladimir Ozerov commented on IGNITE-6140:
-----------------------------------------
[~tledkov-gridgain], my comments:
1) {{JdbcThinDataSource}} should not extend {{ConnectionPropertiesImpl}}.
Instead, it should has an instance of {{ConnectionPropertiesImpl}} inside,
which is re-created from scratch every time user set's new URL. From what I see
currently properties are not reset properly when URL changes (e.g. some
previously initialized properties will remain untouched). Need to add more
tests. All setter and getter methods should reside in directly data source
class.
2) {{JdbcThinDataSource#setLogWriter}} - why cant we simply set {{out}}? I do
not think it is a good idea to play with static state - e.g. what if user use
both data source and normal connections in the same app?
3) {{dbcThinDriver#getParentLogger}} - looks like we should implement it.
> JDBC thin: implement DataSource interface
> -----------------------------------------
>
> Key: IGNITE-6140
> URL: https://issues.apache.org/jira/browse/IGNITE-6140
> Project: Ignite
> Issue Type: Task
> Components: jdbc
> Affects Versions: 2.1
> Reporter: Taras Ledkov
> Assignee: Taras Ledkov
> Priority: Major
> Fix For: 2.5
>
>
> Implemented {{DataSource}} interface is required for JDBC compliance.
> Also it us useful for external connection pool implementation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
