[
https://issues.apache.org/jira/browse/IGNITE-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453690#comment-16453690
]
Alexander Menshikov commented on IGNITE-6430:
---------------------------------------------
[~agura]
After fixes described in last comment the test works fine: passed without any
problem over than 600 times locally and 120 times on TC.
See [TC
result|https://ci.ignite.apache.org/viewLog.html?buildId=1246058&buildTypeId=IgniteTests24Java8_Cache3&tab=testsInfo].
Also, I took a look at the calculation of *getEstimatedRebalancingFinishTime*.
And in brief *finishTime* always not less than *U.currentTimeMillis()* at some
point in time when it was set if it's not a *-1L*. So after fixes, the test can
fail with the assertion from a task description only when rebalancing truly
took a lot of time.
I will clean PR and will update status when it becomes ready for merge.
> CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime test fails
> periodically.
> ----------------------------------------------------------------------------------------
>
> Key: IGNITE-6430
> URL: https://issues.apache.org/jira/browse/IGNITE-6430
> Project: Ignite
> Issue Type: Bug
> Reporter: Andrey Gura
> Assignee: Alexander Menshikov
> Priority: Major
> Labels: MakeTeamcityGreenAgain
>
> {{CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime}} test
> fails periodically.
> {noformat}
> [2017-09-18 15:18:20,073][ERROR][main][root] Test failed.
> junit.framework.AssertionFailedError: Expected less 5000, Actual:-100969
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.TestCase.assertTrue(TestCase.java:192)
> at
> org.apache.ignite.internal.processors.cache.CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime(CacheGroupsMetricsRebalanceTest.java:261)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2000)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:132)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1915)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> After fix test should be unmuted on TC.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
