[ 
https://issues.apache.org/jira/browse/IGNITE-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453833#comment-16453833
 ] 

Alexei Scherbakov edited comment on IGNITE-8277 at 4/26/18 10:52 AM:
---------------------------------------------------------------------

[~ivan.glukos],

I reviewed your contribution and have some comments:

1. Information about partitions in CacheInfo.primary|backup is passed not 
efficiently.

I suggest to remove listed below fields from CacheInfo because it can lead to 
OOM with large number of caches/nodes and make separate command for listing 
partitions ownership using more efficient approach (collect info per cache 
group with compression).

private Map<ClusterNode, int[]> primary;
private Map<ClusterNode, int[]> backups;
public List<List<ClusterNode>> assignment;
public List<List<ClusterNode>> idealAssignment;
private Map<UUID, Set<Integer>> primaryMap;
private Map<UUID, Set<Integer>> backupMap;

2. IDLE_ANALYZE can produce OOM on large data sets.

I suggest to implement streaming comparison approach, until what this command 
should be postponed.

3. What is zone,cell, dc ?


was (Author: ascherbakov):
[~ivan.glukos],

I reviewed your contribution and have some comments:

1. Information about partitions in CacheInfo.primary|backup is passed not 
efficiently.

I suggest to remove listed below fields from CacheInfo because it can lead to 
OOM with large number of caches/nodes and make separate command for listing 
partitions ownership using more efficient approach (collect info per cache 
group with compression).

private Map<ClusterNode, int[]> primary;
private Map<ClusterNode, int[]> backups;
public List<List<ClusterNode>> assignment;
public List<List<ClusterNode>> idealAssignment;
public AffinityTopologyVersion topologyVersion;
private Map<UUID, Set<Integer>> primaryMap;
private Map<UUID, Set<Integer>> backupMap;

2. IDLE_ANALYZE can produce OOM on large data sets.

I suggest to implement streaming comparison approach, until what this command 
should be postponed.

3. What is zone,cell, dc ?

> Add utilities to check and display cache info
> ---------------------------------------------
>
>                 Key: IGNITE-8277
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8277
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Goncharuk
>            Assignee: Ivan Rakov
>            Priority: Major
>
> It will be useful to add some utilities to control.sh script to control 
> cluster state in production environments:
> 1) An utility which checks partition consistency on primary and backup nodes. 
> This utility should work on an idle cluster and check only owning partitions. 
> Also there should be a way to run per-key comparison of a partition on two 
> selected nodes in a grid.
> 2) An utility to display cache info such as a list of caches with their IDs, 
> the list of cache groups, current partition owners, number of currently 
> owning, moving, renting partitions in the grid
> 3) An utility to display contented keys in caches
> 4) An utility to check the validity of all indexes. Essentially, it will take 
> an iterator over a partition and check that the given entry is reachable via 
> all defined indexes.
> I suggest to add the given commands to {{./bin/control.sh}} script under a 
> new {{--cache}} subcommand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to