[ https://issues.apache.org/jira/browse/IGNITE-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456493#comment-16456493 ]
David Harvey edited comment on IGNITE-8406 at 4/27/18 2:06 PM: --------------------------------------------------------------- I think we are saying the same thing: The current post condition on flush() is that all futures are done but the apply function has not necessarily been called for all of them, and nothing about successful storing of the data can be inferred by flush() completing without throwing. Simply making those clear in the Javadoc would be a sufficient solution. If there was a desire to make a stronger statement about what you can assume from flush() completing w/o throwing, I think there would need to be a code minor change. was (Author: syssoftsol): The current post condition on flush() is that all futures are done but the apply function has not necessarily been called for all of them, and nothing about successful storing of the data can be inferred by flush() completing without throwing. Simply making those clear in the Javadoc would be a sufficient solution. If there was a desire to make a stronger statement about what you can assume from flush() completing w/o throwing, I think there would need to be a code minor change. > Update IgniteDataStreamer.flush() javadoc > ----------------------------------------- > > Key: IGNITE-8406 > URL: https://issues.apache.org/jira/browse/IGNITE-8406 > Project: Ignite > Issue Type: Task > Components: streaming > Affects Versions: 2.4 > Reporter: Andrey Kuznetsov > Priority: Minor > Fix For: 2.6 > > > Current {{flush()}} implementation can throw {{CacheException}} if one or > more futures previously returned by {{addData()}} have been completed > exceptionally. This behavior should be described in {{IgniteDataStreamer}} > javadoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)