[
https://issues.apache.org/jira/browse/IGNITE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457645#comment-16457645
]
Dmitriy Pavlov commented on IGNITE-8219:
----------------------------------------
Checked TC and it seems it is OK, but I have proposals related to usability.
1)
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.Get#checkLockRetry
What if user will see exception
Maximum of retries 1000 reached.
What should user do? It is not clear where retries is reached, what can be done
with it to avoid. So I suggest to improve this error message.
2) Second proposal is optional and up to author: add Nullable annotation to
FailureProcessor.
3) log field seems to be unused in H2TreeIndex, so I suggest to remove it.
4) MetastorageTree new parameter is not added to javadoc, I suggest to revise
similar places in PR.
5) readPage I don't understand why pageAddr is checked to be 0L in finally
block.
For future I suggest to create usource review, because PR has several
modifications and it is convinitent to use upsource for commenting near the
code.
> B+Tree operation may result in an infinite loop in some case
> -------------------------------------------------------------
>
> Key: IGNITE-8219
> URL: https://issues.apache.org/jira/browse/IGNITE-8219
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.4
> Reporter: Alexey Stelmak
> Assignee: Alexey Stelmak
> Priority: Major
> Fix For: 2.5
>
>
> B+Tree operation may result in an infinite loop in case. Test
> DynamicIndexServerCoordinatorBasicSelfTest#testCreateIndexWithInlineSizePartitionedAtomic
> region size = 512Mb, KEY_BEFORE=10000, KEY_AFTER=20000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
