[
https://issues.apache.org/jira/browse/IGNITE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457705#comment-16457705
]
Ivan Rakov commented on IGNITE-8347:
------------------------------------
[~dpavlov], some comments:
1. DelayedPageReplacementTracker#delayedPageWrite - missing space between
"pageSize" and "this"
2. DelayedPageReplacementTracker#close is redundant. Test passes even if we
won't clear map on grid stop. We don't clear many other maps in PageMemory,
they just got garbage collected.
3. I looked at MemoryLeaksOnRestartNodeTest. Now I think that it's good
cadidate for including in regular test suite. We should clean it up a bit:
3.1. Remove "test.hprof" file after test stop
3.2. setDataRegionConfigurations call is reported by "Redundant array creation
for calling varargs method" inspection
3.3. Thread.sleep is reported by "Call to 'Thread.sleep()' in a loop, probably
busy-waiting" inspection, could be replaced by U.sleep
> Memory leaks on restart Ignite node with enabled persistence at ThreadLocal
> ---------------------------------------------------------------------------
>
> Key: IGNITE-8347
> URL: https://issues.apache.org/jira/browse/IGNITE-8347
> Project: Ignite
> Issue Type: Bug
> Components: persistence
> Affects Versions: 2.4
> Reporter: Taras Ledkov
> Assignee: Dmitriy Pavlov
> Priority: Critical
> Fix For: 2.6
>
>
> Memory leaks on restart Ignite node with enabled persistence at ThreadLocal.
> The ThreadLocal {{DelayedPageReplacementTracker#delayedPageWriteThreadLoc}}
> looks suspicious.
> I've added the simple test to memory leak on restart Ignite nodes from the
> thread that is not terminated after node stopped.
> This case is very useful e.g. for all jUnit cache tests that starts Ignite
> cluster from the {{beforeTestsStarted()}} (this method is called from the
> {{main}} thread and alive for all tests in a test suite).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
