[
https://issues.apache.org/jira/browse/IGNITE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458236#comment-16458236
]
Valentin Kulichenko commented on IGNITE-6846:
---------------------------------------------
[~Alexey Kuznetsov], sorry for big delays. I looked at the code, here are some
comments:
* There are conflicts again, please resolve them so that we can do the merge.
* Please rename {{getAverageEntryProcessorInvocationTime}} to
{{getEntryProcessorAverageInvocationTime}}. Same goes for {{max}} and {{min}}.
All entry processor related metrics should start with {{getEntryProcessor...}}.
* What is {{DHT_ATOMIC_TRANSFORM_OP_FLAG_MASK}} and why is it introduced?
[[email protected]], I'm overall OK with the change, but would be good if
someone more experienced in cache internals does the review. There are
modifications in cache messages and other deep internals, I'm not completely
sure we are not breaking anything.
> Add metrics for entry processor invocations
> -------------------------------------------
>
> Key: IGNITE-6846
> URL: https://issues.apache.org/jira/browse/IGNITE-6846
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Affects Versions: 2.3
> Reporter: Valentin Kulichenko
> Assignee: Alexey Kuznetsov
> Priority: Critical
> Labels: iep-6
> Fix For: 2.6
>
>
> {{CacheMetrics}} object has multiple metrics for various cache operations
> like {{get}}, {{put}} and {{remove}}, but nothing for
> {{invoke}}/{{EntryProcessor}}. It makes sense to add such metrics, for
> example:
> * Total number of `invoke` operations executed.
> * Number of `invoke` operations that included updates.
> * Number of read-only `invoke` operations.
> * Min/max/avg execution time.
> * ...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
