[jira] [Commented] (IGNITE-8464) WALIterator broken (race on the switch to the next segment during iteration and concurrent archiving same segment)

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/IGNITE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472129#comment-16472129
 ] 

ASF GitHub Bot commented on IGNITE-8464:
----------------------------------------

GitHub user akalash opened a pull request:

    https://github.com/apache/ignite/pull/3982

    IGNITE-8464 removed file format after archive

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-8464

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3982
    
----
commit 502e52d687e3b796b351cbb8e916d331a64675c6
Author: Anton Kalashnikov <kaa.dev@...>
Date:   2018-05-11T15:40:13Z

    IGNITE-8464 removed file format after archive

----


> WALIterator broken (race on the switch to the next segment during iteration 
> and concurrent archiving same segment)
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-8464
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8464
>             Project: Ignite
>          Issue Type: Bug
>          Components: persistence
>    Affects Versions: 2.5
>            Reporter: Dmitriy Govorukhin
>            Assignee: Anton Kalashnikov
>            Priority: Major
>             Fix For: 2.6
>
>
> FileArchiver
> {code}
> final SegmentArchiveResult res = archiveSegment(toArchive);
> synchronized (this) {
>  while (locked.containsKey(toArchive) && !stopped)
>  wait();
> }
> // Firstly, format working file
> if (!stopped)
>  formatFile(res.getOrigWorkFile());
> synchronized (this) {
>  // Then increase counter to allow rollover on clean working file
>  changeLastArchivedIndexAndNotifyWaiters(toArchive);
>  notifyAll();
> }
> {code}
> Some thread may try read segments when archive formating file in work dir 
> (formatFile not synchronized), last archived index is still not updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)