[
https://issues.apache.org/jira/browse/IGNITE-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473274#comment-16473274
]
ASF GitHub Bot commented on IGNITE-5965:
----------------------------------------
GitHub user andrewmed opened a pull request:
https://github.com/apache/ignite/pull/3988
IGNITE-5965 fix Flaky failure of GridServiceProcessorMultiNodeConfigS…
Test fixed by decreasing connection timeout. Now
GridServiceProcessorMultiNodeConfigSelfTest.testDeployOnEachNodeUpdateTopology
that should have failed earlier because of topology not being updated on nodes
exit (cause of failures), succeeds but runs > 10 sec. This fix gives 200/200
success rate, but I am not really sure if the approach is right. Needs reviewing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewmed/ignite IGNITE-5965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3988
----
commit 82cf7f21c6532c6d4daa586e77a914b7049ac13a
Author: AMedvedev <amedvedev@...>
Date: 2018-05-12T21:02:16Z
IGNITE-5965 fix Flaky failure of
GridServiceProcessorMultiNodeConfigSelfTest.testDeployOnEachNodeUpdateTopology
----
> Ignite Basic: Flaky failure of
> GridServiceProcessorMultiNodeConfigSelfTest.testDeployOnEachNodeUpdateTopology
> --------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-5965
> URL: https://issues.apache.org/jira/browse/IGNITE-5965
> Project: Ignite
> Issue Type: Test
> Affects Versions: 2.1
> Reporter: Ivan Rakov
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Attachments: log.txt
>
>
> Test has 85% success rate in master:
> http://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&testNameId=-2642357454043293898&tab=testDetails&branch_Ignite20Tests=%3Cdefault%3E
> Flaky failure is reproduced locally with similar success rate (24/30, Win 10).
> {noformat}
> junit.framework.AssertionFailedError:
> Expected :4
> Actual :5
> <Click to see difference>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.Assert.assertEquals(Assert.java:241)
> at junit.framework.TestCase.assertEquals(TestCase.java:409)
> at
> org.apache.ignite.internal.processors.service.GridServiceProcessorAbstractSelfTest.checkCount(GridServiceProcessorAbstractSelfTest.java:765)
> at
> org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeConfigSelfTest.checkDeployOnEachNodeUpdateTopology(GridServiceProcessorMultiNodeConfigSelfTest.java:287)
> at
> org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeConfigSelfTest.testDeployOnEachNodeUpdateTopology(GridServiceProcessorMultiNodeConfigSelfTest.java:144)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2000)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:132)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1915)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
