[ 
https://issues.apache.org/jira/browse/IGNITE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479312#comment-16479312
 ] 

ASF GitHub Bot commented on IGNITE-8405:
----------------------------------------

GitHub user Jokser opened a pull request:

    https://github.com/apache/ignite/pull/4019

    IGNITE-8405 Backport to 2.4

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-gg-13827

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4019
    
----
commit 47d05b2eb1ecfef225b4f3460b0eca5122f96b15
Author: Ivanov Petr <pivanov@...>
Date:   2018-01-29T20:17:41Z

    IGNITE-7534: Removed ClusterGroupExample duplicate. Fixes #3446.
    
    Signed-off-by: Valentin Kulichenko <valentin.kuliche...@gmail.com>

commit 79cc7728c87d942316213679f39cfeee46f9bfee
Author: zaleslaw <zaleslaw.sin@...>
Date:   2018-01-30T14:25:08Z

    IGNITE-7567: Fixed bug with datasest in examples
    
    this closes #3453
    
    (cherry picked from commit b42a5c5)

commit 915dd2966084d78f7b4f3d482e6bd25f860c1e23
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-01-31T08:22:26Z

    IGNITE-7569 Fixed index rebuild future - Fixes #3454.

commit 8ea8609259039852ab0c26f26ac528c1ffae7c94
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-01-31T08:24:57Z

    IGNITE-7577 Fixing public API active flag on baseline changes - Fixes #3455.

commit d1a23c684dfadedf2b28966a223684827f3c5d7b
Author: David Wimsey <david@...>
Date:   2018-01-31T08:47:25Z

    IGNITE-7576 Scripts: fix version check regexp to handle OpenJDK
    
    This closes #3456

commit c8ce1f66e98b3174d771a3b801a2538499dc2c3d
Author: Ivan Rakov <ivan.glukos@...>
Date:   2018-01-31T09:51:09Z

    IGNITE-7475 Improved VerifyBackupPartitionsTask to calculate partition 
hashes in parallel - Fixes #3407.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>

commit 258ff4299da20122d7c387cb8579264035c93c18
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-01-31T13:52:24Z

    IGNITE-7573 Fixed full API tests to be compliant with baseline topology

commit aca3b8c664de8dcbbfeabbb0f8c252194d6ad1b2
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-31T16:49:07Z

    IGNITE-7473 .NET: Fix ConfigurationManager assembly error on Linux

commit 7bb61dfb1dcbcd7592222f159618a008bd02f6e6
Author: Alexey Kuznetsov <akuznetsov@...>
Date:   2018-02-01T08:22:53Z

    ignite-2.4.0 Update version.
    
    (cherry picked from commit 2e43749)

commit 254ed3a9c32d092702a0461509bf867cbd7cdee6
Author: Alexey Kuznetsov <akuznetsov@...>
Date:   2018-02-01T08:22:53Z

    ignite-2.4.0 Update version.
    
    (cherry picked from commit 2e43749)

commit d5782c53b8beab17ea4f953ad009d71b02fc335c
Author: artemmalykh <amalykh@...>
Date:   2018-02-01T09:43:02Z

    IGNITE-7590: fixed tree example
    
    this closes #3459
    
    (cherry picked from commit a9d40a7)

commit c1a9c0a404d77fba08170bedf14844f87abe3028
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-02-01T10:17:28Z

    IGNITE-7569 Fixing index rebuild future

commit e43799ce70cdbe03d9e206381d1d5138b820b075
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-02-01T13:39:17Z

    IGNITE-7520 Provide util-methods to get baseline from context - Fixes #3431.

commit a54bfd1a0906cee8394a0b495f61549ab63e4346
Author: dpavlov <dpavlov@...>
Date:   2018-02-01T15:31:12Z

    IGNITE-7599 Missed licenses in ignite-direct-io module
    
    Signed-off-by: Anton Vinogradov <a...@apache.org>
    
    (cherry picked from commit d88af9b)
    Signed-off-by: Anton Vinogradov <a...@apache.org>

commit 8f5fc7cfb0624cf2048efad38dfff32f782116e8
Author: Sergey Chugunov <sergey.chugunov@...>
Date:   2018-02-02T08:24:29Z

    IGNITE-7580 Fix compatibilityMode flag consistency
    
    This closes #3466
    
    (cherry picked from commit 8f2045e)

commit d3ddd50cb2b889173176b6c47c9ff61410e1d909
Author: Ilya Lantukh <ilantukh@...>
Date:   2018-02-07T10:33:28Z

    IGNITE-7514 Affinity assignment should be recalculated when primary node is 
not OWNER
    
    (cherry picked from commit faf50f1)

commit d3745e9d0a3ff5a64fba494889b7e2605f3af6bb
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date:   2018-02-07T18:10:32Z

    IGNITE-7639 Fixed NPE

commit 421b2b9554cc0400be3ec95c07efffca409d07dd
Author: Stanislav Lukyanov <slukyanov@...>
Date:   2018-02-08T22:25:11Z

    IGNITE-7464 - Add property to configure time between node connection 
attempts - Fixes #3493

commit f7c16855ba802d9d47048521aec7e14285e4a281
Author: Pavel Kovalenko <jokserfn@...>
Date:   2018-02-09T13:55:15Z

    IGNITE-7540 Prevent page memory metadata corruption during checkpoint and 
group destroying. - Fixes #3490.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>

commit 2eec607b36186c05f92fae71b30d61d43eda4a69
Author: Nikolay Izhikov <nizhikov@...>
Date:   2018-02-09T04:00:54Z

    IGNITE-7337: Implementation of saving DataFrame to Ignite SQL tables - 
Fixes #3438.

commit c92f167fc491078f02b9f94fe89edafc2902ebc2
Author: ilantukh <ilantukh@...>
Date:   2018-02-14T12:40:13Z

    Updated version in properties.

commit 1ecf348dd429cf7861b414e0e5a7776b72dba281
Author: Sergey Chugunov <sergey.chugunov@...>
Date:   2018-02-16T13:21:12Z

    IGNITE-7699 BinaryMetadata exchange should not be triggered if metadata was 
not updated - Fixes #3523.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>
    
    (cherry-picked from commit bcd3881)

commit 2458bd08a5b501b3eeb5caf0ae6dcaa2bcccd915
Author: EdShangGG <eshangareev@...>
Date:   2018-02-16T13:29:49Z

    IGNITE-7676 Add affinity version to snapshot plugin stub - Fixes #3510.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>
    (cherry picked from commit b6d21fb)

commit bfdcda7a2a6b5cf64f15ed169d2beb886f131fac
Author: EdShangGG <eshangareev@...>
Date:   2018-02-12T16:36:30Z

    IGNITE-7626 Unify code in test which cleans up persistence directories - 
Fixes #3477.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>
    (cherry picked from commit a0997b9)

commit 2e92e0094b270aa8489e66d94bfcf15eadabfb4f
Author: EdShangGG <eshangareev@...>
Date:   2018-02-12T18:44:10Z

    IGNITE-7626 Unify code in test which clean up persistence directories - 
Fixes #3512.
    
    Signed-off-by: Alexey Goncharuk <alexey.goncha...@gmail.com>
    (cherry picked from commit 6f6f8dd)

commit 3f86c127c78065999663a4fc4eaedb5e5d4bee1c
Author: EdShangGG <eshangareev@...>
Date:   2018-02-12T18:26:31Z

    compilation fix

commit 0b9322c566f9b464291854142ac02495bd1817e4
Author: gg-shq <kshirokov@...>
Date:   2018-02-07T11:28:04Z

    IGNITE-6917: Implemented SQL COPY command.

commit c5e386ca96750213bddcd98d0af0c589fee476ca
Author: gg-shq <kshirokov@...>
Date:   2018-02-07T15:31:27Z

    IGNITE-7586: Added COPY command into the JDBC example.
    
    This closes #3485

commit d8203e2d81f8fbf0f7fbe5e710c9908f2fcb8307
Author: shq <kirill.shirokov@...>
Date:   2018-02-15T10:36:00Z

    IGNITE-7709: SQL COPY command: make sure file name is always quoted. This 
closes #3526.

commit 1185993ee7cd83695388f698f18f95b43e15de06
Author: devozerov <vozerov@...>
Date:   2018-02-15T11:00:42Z

    IGNITE-7714: SQL COPY command: fixed "Table not found" issue on the client 
node.

----


> Sql query may see intermediate results of topology changes and perform 
> mapping incorrectly
> ------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-8405
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8405
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache, sql
>    Affects Versions: 2.4
>            Reporter: Pavel Kovalenko
>            Assignee: Pavel Kovalenko
>            Priority: Major
>             Fix For: 2.5
>
>
> Affected test: IgniteStableBaselineCacheQueryNodeRestartsSelfTest
> Sql query do mapping in following way:
> 1) If there is at least 1 moving partition query will be mapped to current 
> partition owners
> 2) In other case affinity mapping will be used.
> In case of first approach query may see not final partition state if mapping 
> happens during PME. There is "setOwners()" method which does partition 
> movement one-by-one, each time obtaining topology write lock. If query 
> mapping happens in this time it may see that there is some moving partition 
> and performed mapping to OWNING partition which will be moved to MOVING on 
> next "setOwners()" invocation.
> As result we may query from invalid partitions.
> As intermediate solution "setOwners()" method should be refactored in a batch 
> way to perform ALL partitions state changes to MOVING in one operation.
> As general solution query mapping should be revisited, especially 
> "isPreloadingActive" method, to take into account given topology version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to