[jira] [Commented] (IGNITE-7759) Logger does not print sockTimeout and ackTimeout default values for TcpDiscoverySpi

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/IGNITE-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482068#comment-16482068
 ] 

ASF GitHub Bot commented on IGNITE-7759:
----------------------------------------

GitHub user ruchirchoudhry opened a pull request:

    https://github.com/apache/ignite/pull/4031

    IGNITE-7759 --> Made changes for this bug

    Hello @gromtech 
    
    Pls review it 
    
    Thanks,
    Ruchir

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ruchirchoudhry/ignite IGNITE-7759

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4031
    
----
commit 92294c4a6715ed3465f2a5ebab3cb7eeea2296eb
Author: Ruchir Choudhry <ruchirchoudhry@...>
Date:   2018-05-20T22:37:55Z

    IGNITE-7759 --> Made changes for this bug

----


> Logger does not print sockTimeout and ackTimeout default values for 
> TcpDiscoverySpi
> -----------------------------------------------------------------------------------
>
>                 Key: IGNITE-7759
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7759
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.9, 2.1, 2.3
>            Reporter: Roman Guseinov
>            Assignee: ruchir choudhry
>            Priority: Minor
>              Labels: newbie
>
> Logger does not print sockTimeout and ackTimeout default values for 
> TcpDiscoverySpi
> Before starting TcpDiscoverySpi logger prints the following message (debug 
> mode is enabled):
> {code:java}
> [main][GridDiscoveryManager] Starting SPI: TcpDiscoverySpi [addrRslvr=null, 
> sockTimeout=0, ackTimeout=0, marsh=JdkMarshaller 
> [clsFilter=org.apache.ignite.internal.IgniteKernal$5@402e37bc], reconCnt=10, 
> reconDelay=2000, maxAckTimeout=600000, forceSrvMode=false, 
> clientReconnectDisabled=false]
> {code}
> Note, that sockTimeout=0 and ackTimeout=0. Default values initializing 
> happens after TcpDiscoverySpi.spiStart is called:
> {code:java}
> public class TcpDiscoverySpi extends IgniteSpiAdapter implements DiscoverySpi 
> {
>     /** Node attribute that is mapped to node's external addresses (value is 
> <tt>disc.tcp.ext-addrs</tt>). */
>     /** {@inheritDoc} */
>     @Override public void spiStart(@Nullable String igniteInstanceName) 
> throws IgniteSpiException {
>         initializeImpl();
>     }
>     /**
>      *
>      */
>     private void initializeImpl() {
>         if (impl != null)
>             return;
>         initFailureDetectionTimeout();
>         if (!forceSrvMode && 
> (Boolean.TRUE.equals(ignite.configuration().isClientMode()))) {
>             if (ackTimeout == 0)
>                 ackTimeout = DFLT_ACK_TIMEOUT_CLIENT;
>             if (sockTimeout == 0)
>                 sockTimeout = DFLT_SOCK_TIMEOUT_CLIENT;
>             impl = new ClientImpl(this);
>             ctxInitLatch.countDown();
>         }
>         else {
>             if (ackTimeout == 0)
>                 ackTimeout = DFLT_ACK_TIMEOUT;
>             if (sockTimeout == 0)
>                 sockTimeout = DFLT_SOCK_TIMEOUT;
>             impl = new ServerImpl(this);
>         }
>      
>     }
> }
> {code}
> To avoid confusion I suggest printing default sockTimeout and ackTimeout if 
> they weren't changed like:
> {code:java}
> [main][GridDiscoveryManager] Starting SPI: TcpDiscoverySpi [addrRslvr=null, 
> sockTimeout=5000, ackTimeout=5000, marsh=JdkMarshaller 
> [clsFilter=org.apache.ignite.internal.IgniteKernal$5@402e37bc], reconCnt=10, 
> reconDelay=2000, maxAckTimeout=600000, forceSrvMode=false, 
> clientReconnectDisabled=false]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)