[
https://issues.apache.org/jira/browse/IGNITE-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504454#comment-16504454
]
ASF GitHub Bot commented on IGNITE-8724:
----------------------------------------
GitHub user zstan opened a pull request:
https://github.com/apache/ignite/pull/4145
IGNITE-8724 U.warn mislead implementation fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8724
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4145
----
commit 1eacc9477ba05cc5b7908718951bbb1f0999b877
Author: Evgeny Stanilovskiy <estanilovskiy@...>
Date: 2018-06-07T09:27:31Z
IGNITE-8724 U.warn mislead implementation fix
----
> Skip logging 3-rd parameter while calling U.warn with initialized logger.
> -------------------------------------------------------------------------
>
> Key: IGNITE-8724
> URL: https://issues.apache.org/jira/browse/IGNITE-8724
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 2.5
> Reporter: Stanilovsky Evgeny
> Assignee: Stanilovsky Evgeny
> Priority: Major
>
> There are a lot of places where exception need to be logged, for example :
> {code:java}
> U.warn(log,"Unable to await partitions release future", e);
> {code}
> but current U.warn realization silently swallow it.
> {code:java}
> public static void warn(@Nullable IgniteLogger log, Object longMsg,
> Object shortMsg) {
> assert longMsg != null;
> assert shortMsg != null;
> if (log != null)
> log.warning(compact(longMsg.toString()));
> else
> X.println("[" + SHORT_DATE_FMT.format(new java.util.Date()) + "]
> (wrn) " +
> compact(shortMsg.toString()));
> }
> {code}
> fix, looks like simple add:
> {code:java}
> public static void warn(@Nullable IgniteLogger log, Object longMsg,
> Throwable ex) {
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
