[ 
https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529709#comment-16529709
 ] 

ASF GitHub Bot commented on IGNITE-8905:
----------------------------------------

GitHub user sergey-chugunov-1985 opened a pull request:

    https://github.com/apache/ignite/pull/4288

    IGNITE-8905 incorrect assertion was replaced with if-check

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-8905

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4288
    
----
commit f2194169e9eda7232bc642bf3b1b5a1ad4967af0
Author: Sergey Chugunov <sergey.chugunov@...>
Date:   2018-07-02T10:54:55Z

    IGNITE-8905 incorrect assertion was replaced with if-check

----


> Incorrect assertion in GridDhtPartitionsExchangeFuture
> ------------------------------------------------------
>
>                 Key: IGNITE-8905
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8905
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Sergey Chugunov
>            Assignee: Sergey Chugunov
>            Priority: Major
>             Fix For: 2.7
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture 
> which is correct only in situation when client has to reconnect due to too 
> short EXCHANGE_HISTORY.
> Exceptions from other situations like not being able to acquire file lock are 
> also passed to client node in FullMessage.
> This assertion should be removed and check should be introduced instead: if 
> this exception is intended to be thrown on current client node, we should do 
> this, otherwise old program flow should be executed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to