[
https://issues.apache.org/jira/browse/IGNITE-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534589#comment-16534589
]
ASF GitHub Bot commented on IGNITE-8944:
----------------------------------------
GitHub user dkarachentsev opened a pull request:
https://github.com/apache/ignite/pull/4320
IGNITE-8944 - TcpDiscoverySpi: set connection check frequency to fixe…
…d value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8944
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4320
----
commit f316865b950e4322c783d8cf0e6ec02686f60cd4
Author: dkarachentsev <dkarachentsev@...>
Date: 2018-07-06T08:54:04Z
IGNITE-8944 - TcpDiscoverySpi: set connection check frequency to fixed value
----
> TcpDiscoverySpi: set connection check frequency to fixed value
> --------------------------------------------------------------
>
> Key: IGNITE-8944
> URL: https://issues.apache.org/jira/browse/IGNITE-8944
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.5
> Reporter: Dmitry Karachentsev
> Assignee: Dmitry Karachentsev
> Priority: Major
> Labels: discovery
> Fix For: 2.7
>
>
> Now connCheckFreq value calculated by some not obvious code:
> {code:java}
> private void initConnectionCheckFrequency() {
> if (spi.failureDetectionTimeoutEnabled())
> connCheckThreshold = spi.failureDetectionTimeout();
> else
> connCheckThreshold = Math.min(spi.getSocketTimeout(),
> spi.metricsUpdateFreq);
> for (int i = 3; i > 0; i--) {
> connCheckFreq = connCheckThreshold / i;
> if (connCheckFreq > 10)
> break;
> }
> assert connCheckFreq > 0;
> if (log.isInfoEnabled())
> log.info("Connection check frequency is calculated: " +
> connCheckFreq);
> }
> {code}
> It should be replaced with constant.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
