[ 
https://issues.apache.org/jira/browse/IGNITE-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536759#comment-16536759
 ] 

kcheng.mvp edited comment on IGNITE-8376 at 7/9/18 10:22 AM:
-------------------------------------------------------------

[~DmitriyGovorukhin][~agoncharuk][~kuaw26]

Once thing need to clarify with you. from the source code. right now there are 
just two type of *internal* event as below

you means we make the mentioned events as *internal* as well?

1: *Cluster level* EVT_CLUSTER_ACTIVATED, EVT_CLUSTER_DEACTIVATED, 
EVT_CLUSTER_ACTIVATION_FAILED
2: *Node Level* EVT_NODE_ACTIVATE,EVT_NODE_DEACTIVATE,EVT_NODE_ACTIVATING, 
EVT_NODE_DEACTIVATING

is my understanding correct? 

{code:java}
   /**
     * Checks whether or not this event is an internal event.
     * <p>
     * Internal event types are always recordable for notification purposes
     * but may not be sent down to SPI level for storage and subsequent 
querying.
     *
     * @param type Event type.
     * @return {@code true} if this is an internal event.
     */
    private boolean isInternalEvent(int type) {
        return type == EVT_DISCOVERY_CUSTOM_EVT || 
F.contains(EVTS_DISCOVERY_ALL, type);
    }
{code}



was (Author: kcheng.mvp):
[~DmitriyGovorukhin][~agoncharuk][~kuaw26]

Once thing need to clarify with you. from the source code. right now there are 
just two type of *internal* event as below

you means we make the mentioned events as *internal* as well?

1: "Cluster level* EVT_CLUSTER_ACTIVATED, EVT_CLUSTER_DEACTIVATED, 
EVT_CLUSTER_ACTIVATION_FAILED
2: "Node Level" EVT_NODE_ACTIVATE,EVT_NODE_DEACTIVATE,EVT_NODE_ACTIVATING, 
EVT_NODE_DEACTIVATING

is my understanding correct? 

{code:java}
   /**
     * Checks whether or not this event is an internal event.
     * <p>
     * Internal event types are always recordable for notification purposes
     * but may not be sent down to SPI level for storage and subsequent 
querying.
     *
     * @param type Event type.
     * @return {@code true} if this is an internal event.
     */
    private boolean isInternalEvent(int type) {
        return type == EVT_DISCOVERY_CUSTOM_EVT || 
F.contains(EVTS_DISCOVERY_ALL, type);
    }
{code}


> Add cluster (de)activation events
> ---------------------------------
>
>                 Key: IGNITE-8376
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8376
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Goncharuk
>            Assignee: kcheng.mvp
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.7
>
>
> Currently, we do not have any way to detect that a cluster got activated, 
> which results in busy-loops polling {{cluster().active()}}.
> I suggest to add new events, {{EVT_CLUSTER_ACTIVATED}}, 
> {{EVT_CLUSTER_DEACTIVATED}}, {{EVT_CLUSTER_ACTIVATION_FAILED}} which will be 
> fired when corresponding steps are completed. The event should contain, if 
> possible, information about the activation source (public API or 
> auto-activation), topology version on which activation was performed. The 
> fail event should contain information about the cause of the failure. If 
> needed, a new class for this event should be introduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to