[
https://issues.apache.org/jira/browse/IGNITE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547190#comment-16547190
]
ruchir choudhry edited comment on IGNITE-9023 at 7/17/18 11:22 PM:
-------------------------------------------------------------------
Hello [~ivandasch]
It will only happen if the Debug is on, which is the correct, right,
Do you want we need to record it in the logs file and send to the client also ?
Will appreciate a quick reply, i will be able to pick this one.
----
private void processResourceRequest(UUID nodeId, GridDeploymentRequest req) {
if (log.isDebugEnabled())
log.debug("Received peer class/resource loading request [node=" + nodeId + ",
req=" + req + ']');
// this the place you want me to change ? its happening only is log.Debug is
true. which is the right thing to do , Pls confirm
if (req.responseTopic() == null) {
try
{ req.responseTopic(U.unmarshal(marsh, req.responseTopicBytes(),
U.resolveClassLoader(ctx.config()))); }
catch (IgniteCheckedException e)
{ U.error(log, "Failed to process deployment request (will ignore): " + req,
e); return; }
}
------
Regards, Ruchir
was (Author: ruchirc):
Hello [~ivandasch]
It will only happen if the Debug is on, which is the correct, right,
Do you want we need to record it in the logs file and send to the client also ?
Will appreciate a quick reply, i will be able to pick this one.
----
private void processResourceRequest(UUID nodeId, GridDeploymentRequest req) {
if (log.isDebugEnabled())
log.debug("Received peer class/resource loading request [node=" + nodeId + ",
req=" + req + ']');
// this the place you want me to change ? its happening only is log.Debug is
true. which is the right thing to do , Pls confirm
if (req.responseTopic() == null) {
try {
req.responseTopic(U.unmarshal(marsh, req.responseTopicBytes(),
U.resolveClassLoader(ctx.config())));
}
catch (IgniteCheckedException e) {
U.error(log, "Failed to process deployment request (will ignore): " + req, e);
Regards,
Ruchir
return;
}
}
------
> LinkageError or ClassNotFoundException should not be swollen by
> GridDeploymentCommunication during processing deployment request.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-9023
> URL: https://issues.apache.org/jira/browse/IGNITE-9023
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.5
> Reporter: Ivan Daschinskiy
> Assignee: ruchir choudhry
> Priority: Minor
> Fix For: 2.7
>
>
> In current implementation any error, that is thrown in
> GridDeploymentCommunication#processResourceRequest, is ignored silently.
> Any error should be logged and send to client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
