[
https://issues.apache.org/jira/browse/IGNITE-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563318#comment-16563318
]
Andrew Mashenkov commented on IGNITE-7752:
------------------------------------------
[~roman_s],
I've taken a look at the PR.
Would you please fix javadocs to all classes and methods? Seems, they were
missed in some places.
Also you catch and ignore an Exception in ConsumerTask.
AFAIK, consumer.poll can throw KafkaException when broker become temporary
unavailable and consumer should be re-subscribed after such failure, isn't it?
Also, stopped flag should be checked in this catch block to avoid infinite loop.
Please, let me know if I'm wrong.
> Update Ignite KafkaStreamer to use new KafkaConsmer configuration.
> ------------------------------------------------------------------
>
> Key: IGNITE-7752
> URL: https://issues.apache.org/jira/browse/IGNITE-7752
> Project: Ignite
> Issue Type: Task
> Components: streaming
> Reporter: Andrew Mashenkov
> Assignee: Roman Shtykh
> Priority: Major
> Labels: newbie, streaming
> Fix For: 2.7
>
>
> Seems, for now it is impossible to use new style KafkaConsumer configuration
> in KafkaStreamer.
> The issue here is Ignite use
> kafka.consumer.Consumer.createJavaConsumerConnector() method which creates
> old consumer (ZookeeperConsumerConnector).
> We should create a new KafkaConsumer instead which looks like support both,
> old and new style configs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
