[ https://issues.apache.org/jira/browse/IGNITE-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573354#comment-16573354 ]
Ilya Lantukh commented on IGNITE-8724: -------------------------------------- Hi [~zstan], Thanks for contribution! I think that fixing this problem is very important, and I don't see any reason to leave old method in our codebase. Please remove it. If it has any usages where last argument isn't Throwable, feel free to change them. > Skip logging 3-rd parameter while calling U.warn with initialized logger. > ------------------------------------------------------------------------- > > Key: IGNITE-8724 > URL: https://issues.apache.org/jira/browse/IGNITE-8724 > Project: Ignite > Issue Type: Bug > Components: general > Affects Versions: 2.5 > Reporter: Stanilovsky Evgeny > Assignee: Stanilovsky Evgeny > Priority: Major > Fix For: 2.7 > > Attachments: tc.png > > > There are a lot of places where exception need to be logged, for example : > {code:java} > U.warn(log,"Unable to await partitions release future", e); > {code} > but current U.warn realization silently swallow it. > {code:java} > public static void warn(@Nullable IgniteLogger log, Object longMsg, > Object shortMsg) { > assert longMsg != null; > assert shortMsg != null; > if (log != null) > log.warning(compact(longMsg.toString())); > else > X.println("[" + SHORT_DATE_FMT.format(new java.util.Date()) + "] > (wrn) " + > compact(shortMsg.toString())); > } > {code} > fix, looks like simple add: > {code:java} > public static void warn(@Nullable IgniteLogger log, Object longMsg, > Throwable ex) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)