[ https://issues.apache.org/jira/browse/IGNITE-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583689#comment-16583689 ]
Nikolay Izhikov commented on IGNITE-9228: ----------------------------------------- Hello, [~stuartmacd]. 1. Please, as a contributor to this ticket assign it to yourself. 2. I made a review of your changes. Most comments about code style. Please, fix it and answer my questions. https://github.com/apache/ignite/pull/4551#pullrequestreview-147148438 Ignite code style guidlines - https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines > Spark SQL Table Schema Specification > ------------------------------------ > > Key: IGNITE-9228 > URL: https://issues.apache.org/jira/browse/IGNITE-9228 > Project: Ignite > Issue Type: Improvement > Components: spark > Affects Versions: 2.6 > Reporter: Stuart Macdonald > Priority: Major > Fix For: 2.7 > > > The Ignite Spark SQL interface currently takes just “table name” as a > parameter which it uses to supply a Spark dataset with data from the > underlying Ignite SQL table with that name. > To do this it loops through each cache and finds the first one with the > given table name [1]. This causes issues if there are multiple tables > registered in different schema with the same table name as you can only > access one of those from Spark. We could either: > 1. Pass an extra parameter through the Ignite Spark data source which > optionally specifies the schema name. > 2. Support namespacing in the existing table name parameter, ie > “schemaName.tableName” > [1 > ]https://github.com/apache/ignite/blob/ca973ad99c6112160a305df05be9458e29f88307/modules/spark/src/main/scala/org/apache/ignite/spark/impl/package.scala#L119 -- This message was sent by Atlassian JIRA (v7.6.3#76005)