[
https://issues.apache.org/jira/browse/IGNITE-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584863#comment-16584863
]
ASF GitHub Bot commented on IGNITE-9316:
----------------------------------------
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4569
IGNITE-9316 Analyse and improve code coverage in ML module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite_9316
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4569
----
commit 3eee3dc164063493bae312f4c4df5d73110e5d1b
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-17T20:08:07Z
IGNITE-9146 follow-up (phase 2)
- wip
-- verified with diffs overview, rebuild and execution of unit tests
commit 11c22ee340fe52277d1cf43ea8e722b744d6f585
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-17T20:51:58Z
IGNITE-9146 follow-up (phase 2)
- wip
-- verified with diffs overview, rebuild and execution of unit tests
commit f4d8b8782bbf8eae4d1689eee90f05efa807b9da
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T07:23:18Z
IGNITE-9146 follow-up (phase 2)
- wip
-- verified with diffs overview, rebuild and execution of unit tests
commit b3964e3171bdf8dff11496c056d19c95045ce422
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T07:29:31Z
IGNITE-9146 follow-up (phase 2)
- wip (IGNITE-9261 merge follow-up)
-- verified with diffs overview, rebuild and execution of unit tests
commit f3d71d0fa4d462d64a5c551903e3cc0168772b18
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T09:43:40Z
IGNITE-9146 follow-up (phase 2)
- wip (per review of generated coverage report)
-- verified with diffs overview, rebuild and execution of unit tests
commit 494fe53d7792880feb96852079a8f1d518713ec3
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T11:18:47Z
IGNITE-9146 follow-up (phase 2)
- wip (per review of generated coverage report)
-- verified with diffs overview, rebuild and execution of unit tests
commit 52c1dd678564fc9877c3b51c1319591add018c28
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T11:56:14Z
IGNITE-9146 follow-up (phase 2)
- wip (per review of generated coverage report)
-- verified with diffs overview, rebuild and execution of unit tests
commit 401d37c2e27042079d1ada7d7c868d4610d02e30
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T12:04:05Z
Merge branch 'master-ml' into ignite_9146_phase_2
commit a0a2db4403f954d9a09f3027f246438f61c2a5ce
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-08-18T16:44:56Z
IGNITE-9146 follow-up (phase 2)
- wip (per review of generated coverage report)
-- verified with diffs overview, rebuild and execution of unit tests
----
> Analyse and improve code coverage in ML module (follow-up to IGNITE-9146)
> -------------------------------------------------------------------------
>
> Key: IGNITE-9316
> URL: https://issues.apache.org/jira/browse/IGNITE-9316
> Project: Ignite
> Issue Type: Task
> Components: ml
> Affects Versions: 2.6
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
> Labels: unit-test
> Fix For: 2.7
>
> Attachments: 20180818.IgniteMLTestSuite.coverage.zip
>
>
> Studying of coverage reports attached in IGNITE-9146 suggests that many
> default methods in interfaces are not covered by tests.
> In particular the default methods in the following interfaces look like worth
> covering in tests:
> {noformat}
> org.apache.ignite.ml.Model
> org.apache.ignite.ml.math.functions.IgniteTriFunction
> org.apache.ignite.ml.dataset.PartitionDataBuilder
> org.apache.ignite.ml.dataset.PartitionContextBuilder
> org.apache.ignite.ml.dataset.Dataset
> org.apache.ignite.ml.environment.parallelism.Promise
> org.apache.ignite.ml.composition.predictionsaggregator.PredictionsAggregator{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
