[
https://issues.apache.org/jira/browse/IGNITE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586152#comment-16586152
]
ASF GitHub Bot commented on IGNITE-8829:
----------------------------------------
GitHub user NSAmelchev opened a pull request:
https://github.com/apache/ignite/pull/4583
IGNITE-8829
TcpCommunicationSpi: fix configuration properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NSAmelchev/ignite ignite-8829
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4583
----
commit cfb27276cdd5c68862bb77ccfb78d62c9e5ad23e
Author: NSAmelchev <nsamelchev@...>
Date: 2018-08-20T15:55:31Z
Refactoring TcpCommunicationSpi
----
> Some configuration properties of TcpCommunicationSpi does not annotated
> appropriately
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-8829
> URL: https://issues.apache.org/jira/browse/IGNITE-8829
> Project: Ignite
> Issue Type: Bug
> Reporter: Vladislav Pyatkov
> Assignee: Amelchev Nikita
> Priority: Major
>
> When I checked all properties of TcpCommunicationSpi, I have found an issue
> with getting all configuration properties from code. Because a part of them
> not be a configured property, but a part of a real SPI life.
> I should was rid of these issues - all configurable properties must annotate
> as {{IgniteSpiConfiguration}}, but it not done for each.
> I have found at least two properties for which not be done:
> {{connectionsPerNode}}
> {{usePairedConnections}}
> and one property which not appropriate contract (it have only setter, but not
> getter):
> {{addressResolver}}
> Need to revised all properties CommunicationSpi and correct them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
