[
https://issues.apache.org/jira/browse/IGNITE-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592582#comment-16592582
]
ASF GitHub Bot commented on IGNITE-9272:
----------------------------------------
GitHub user zstan opened a pull request:
https://github.com/apache/ignite/pull/4619
IGNITE-9272 j.u.zip.CRC32algo instead of PureJavaCrc32
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4619
----
commit 7479203c7bb4ffa6fecfa6a3d604f1c61a8ddfdb
Author: Evgeny Stanilovskiy <estanilovskiy@...>
Date: 2018-08-24T14:34:05Z
IGNITE-9272 j.u.zip.CRC32algo instead of PureJavaCrc32
----
> PureJavaCrc32 vs j.u.zip.CRC32 benchmark and probably replace.
> --------------------------------------------------------------
>
> Key: IGNITE-9272
> URL: https://issues.apache.org/jira/browse/IGNITE-9272
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.6
> Reporter: Stanilovsky Evgeny
> Assignee: Stanilovsky Evgeny
> Priority: Major
> Fix For: 3.0
>
> Attachments: BenchmarkCRC.java
>
>
> I see that Ignite has its own crc32 realization called: PureJavaCrc32 and
> from desc it seems to be : _The current version is ~10x to 1.8x as fast as
> Sun's native java.util.zip.CRC32 in Java 1.6_ But my jmh tests show opposite
> results.
> + If it really so, looks like backward compatibility would be easy, all that
> need is just to take lower part of long form zip.crc32 realization.
> jmh results:
> Benchmark Mode Cnt Score Error Units
> BenchmarkCRC.Crc32 avgt 5 1521060.716 ± 44083.424 ns/op
> BenchmarkCRC.pureJavaCrc32 avgt 5 4657756.671 ± 177243.254 ns/op
> JMH version: 1.21
> VM version: JDK 1.8.0_131, Java HotSpot(TM) 64-Bit Server VM, 25.131-b11
> VM invoker: /usr/lib/jvm/java-8-oracle/jre/bin/java
> op system : ubuntu 16.10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
