[
https://issues.apache.org/jira/browse/IGNITE-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603166#comment-16603166
]
ASF GitHub Bot commented on IGNITE-9333:
----------------------------------------
akalash commented on a change in pull request #3: IGNITE-9333 Add statistics
page
URL: https://github.com/apache/ignite-teamcity-bot/pull/3#discussion_r214725893
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
##########
@@ -290,14 +298,16 @@ private IgnitePersistentTeamcity(Ignite ignite,
IgniteTeamcityHelper teamcity) {
return mergeByIdToHistoricalOrder(persistedValue, builds);
});
+
+ return buildRefs.stream().skip(cnt < buildRefs.size() ?
buildRefs.size() - cnt : 0).collect(Collectors.toList());
Review comment:
In what case it can be happen(cnt < buildRefs.size())?
And maybe better use some formatting for stream, because one line stream is
too hard to read.
```
buildRefs.stream()
.skip(cnt < buildRefs.size() ? buildRefs.size() - cnt : 0)
.collect(Collectors.toList());
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding page with simple statistic for last 50 runs.
> ---------------------------------------------------
>
> Key: IGNITE-9333
> URL: https://issues.apache.org/jira/browse/IGNITE-9333
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Eduard Shangareev
> Assignee: Nikolai Kulagin
> Priority: Major
>
> Ok, I am proposing to add a new page which would be named "Statistic".
> It should show last 50 "Run All" for master, the columns:
> ||Id||Total tests||Failed tests||Ignored tests|| Muted tests||Total issues
> (count and the list of TC configurations with links) || Total run time ||
> Also, we need to calculate the statistic.
> Totals (all unique tests with issues), average issues/fails per run, median,
> max, min.
> Total issues = Exit codes + JVM Crashes + OOMs + other issues which caused TC
> configuration fail
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
