[
https://issues.apache.org/jira/browse/IGNITE-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605553#comment-16605553
]
Taras Ledkov commented on IGNITE-9161:
--------------------------------------
[~isapego], the review summary:
| Code style | OK |
| API compatibility | OK |
| Product behavior | defaults not changed |
| Documentation | not required |
| Binary compatibility | OK |
| Tests | OK |
| Comments | # The patch fixes performance issue but I've not seen any
benchmarks' results or performance analyze.
# My experience with cpp is not relevant, contact another engineer for in-depth
technical review. |
> CPP: Get rid of additional copy on Get
> --------------------------------------
>
> Key: IGNITE-9161
> URL: https://issues.apache.org/jira/browse/IGNITE-9161
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Affects Versions: 2.0
> Reporter: Igor Sapego
> Assignee: Igor Sapego
> Priority: Major
> Labels: cpp
> Fix For: 2.7
>
>
> Currently, helper classes from {{operations.h}} header file, e.g.
> {{Out1Operation}} contain additional value, that can't be optimized-out by
> the compiler on return, even though the operation itself is a temporary
> object.
> As a solution, such classes should accept and operate on a reference to a
> temporary object, so that [copy
> elision|https://en.wikipedia.org/wiki/Copy_elision] can be used by a compiler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
