[
https://issues.apache.org/jira/browse/IGNITE-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611709#comment-16611709
]
Pavel Konstantinov edited comment on IGNITE-336 at 9/12/18 7:55 AM:
--------------------------------------------------------------------
1) Please fix error message (still contains -enable -disable)
{code}
visor> cache -statistics=on2222 -c=cache1
[WARN ] Goal state for collection of cache statistics is not specified.
[WARN ] Use -enable or -disable flags to toggle collection of cache statistics.
{code}
2) Print error in case if the value is missed
{code}
visor> cache -statistics -c=cache1
Time of the snapshot: 2018-09-12 14:46:12
+===============================================================================================================================+
| Name(@) | Mode | Nodes | Entries (Heap / Off-heap) | Hits
| Misses | Reads | Writes |
+===============================================================================================================================+
| cache1(@c0) | PARTITIONED | 2 | min: 10117 (0 / 10117) | min:
174 | min: 0 | min: 174 | min: 1901 |
| | | | avg: 10167.50 (0.00 / 10167.50) | avg:
351.50 | avg: 727.00 | avg: 1078.50 | avg: 4465.50 |
| | | | max: 10218 (0 / 10218) | max:
529 | max: 1454 | max: 1983 | max: 7030 |
+-------------------------------------------------------------------------------------------------------------------------------+
{code}
3) check if statistics is disabled then print some warning about this, for
example like
{code}
visor> cache -c=cache1
Time of the snapshot: 2018-09-12 14:49:33
WARNING: statistics is disable for this cache, you can enable it using 'cache
-c=<cache> -statistics=on'
+=====================================================================================================================+
| Name(@) | Mode | Nodes | Entries (Heap / Off-heap) | Hits
| Misses | Reads | Writes |
+=====================================================================================================================+
| cache1(@c0) | PARTITIONED | 2 | min: 13749 (0 / 13749) | min: 0
| min: 0 | min: 0 | min: 0 |
| | | | avg: 13871.00 (0.00 / 13871.00) | avg:
0.00 | avg: 0.00 | avg: 0.00 | avg: 0.00 |
| | | | max: 13993 (0 / 13993) | max: 0
| max: 0 | max: 0 | max: 0 |
+---------------------------------------------------------------------------------------------------------------------+
{code}
was (Author: pkonstantinov):
1) Please fix error message
{code}
visor> cache -statistics=on2222 -c=cache1
[WARN ] Goal state for collection of cache statistics is not specified.
[WARN ] Use -enable or -disable flags to toggle collection of cache statistics.
{code}
2) Print error in case if the value is missed
{code}
visor> cache -statistics -c=cache1
Time of the snapshot: 2018-09-12 14:46:12
+===============================================================================================================================+
| Name(@) | Mode | Nodes | Entries (Heap / Off-heap) | Hits
| Misses | Reads | Writes |
+===============================================================================================================================+
| cache1(@c0) | PARTITIONED | 2 | min: 10117 (0 / 10117) | min:
174 | min: 0 | min: 174 | min: 1901 |
| | | | avg: 10167.50 (0.00 / 10167.50) | avg:
351.50 | avg: 727.00 | avg: 1078.50 | avg: 4465.50 |
| | | | max: 10218 (0 / 10218) | max:
529 | max: 1454 | max: 1983 | max: 7030 |
+-------------------------------------------------------------------------------------------------------------------------------+
{code}
3) check if statistics is disabled then print some warning about this, for
example like
{code}
visor> cache -c=cache1
Time of the snapshot: 2018-09-12 14:49:33
WARNING: statistics is disable for this cache, you can enable it using 'cache
-c=<cache> -statistics=on'
+=====================================================================================================================+
| Name(@) | Mode | Nodes | Entries (Heap / Off-heap) | Hits
| Misses | Reads | Writes |
+=====================================================================================================================+
| cache1(@c0) | PARTITIONED | 2 | min: 13749 (0 / 13749) | min: 0
| min: 0 | min: 0 | min: 0 |
| | | | avg: 13871.00 (0.00 / 13871.00) | avg:
0.00 | avg: 0.00 | avg: 0.00 | avg: 0.00 |
| | | | max: 13993 (0 / 13993) | max: 0
| max: 0 | max: 0 | max: 0 |
+---------------------------------------------------------------------------------------------------------------------+
{code}
> We need to add dynamic turn on/off cache statistics for Visor.
> --------------------------------------------------------------
>
> Key: IGNITE-336
> URL: https://issues.apache.org/jira/browse/IGNITE-336
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Affects Versions: sprint-2
> Reporter: Vasiliy Sisko
> Assignee: Pavel Konstantinov
> Priority: Major
>
> We need create task to turn on/off of cache statistics collecting.
> Create Visor command for toggling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
