[ 
https://issues.apache.org/jira/browse/IGNITE-9341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610551#comment-16610551
 ] 

Vyacheslav Koptilin edited comment on IGNITE-9341 at 9/12/18 1:04 PM:
----------------------------------------------------------------------

Hi [~Mmuzaf]

Thanks for your comments!

> Do we really need to keep {{readMetastore(false);}} call at that place?
It seems that it can be avoided. I updated the pull-request in accordance with 
that.

> Generally, I think this is not fair `read-only` metastorage.
This makes sense to me. Perhaps, `GridCacheDatabaseSharedManager.metaStorage()` 
should be changed somehow, as well. [~DmitriyGovorukhin] WDYT?


was (Author: slava.koptilin):
Hi [~Mmuzaf]

Thanks for your comments!

> Do we really need to keep {{readMetastore(false);}} call at that place?
It seems that it can be avoided. I updated the pull-request in accordance with 
that.

> Generally, I think this is not fair `read-only` metastorage.
This makes sense to me. Perhaps, `GridCacheDatabaseSharedManager.metaStorage()` 
should changed somehow, as well. [~DmitriyGovorukhin] WDYT?

> Notify metastorage listeners right before start of discovery processor
> ----------------------------------------------------------------------
>
>                 Key: IGNITE-9341
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9341
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>            Reporter: Ivan Rakov
>            Assignee: Vyacheslav Koptilin
>            Priority: Major
>             Fix For: 2.8
>
>
> onReadyForRead() is called only for inheritors of 
> MetastorageLifecycleListener interface which are started prior to 
> GridCacheProcessor. Listeners are notified at the moment of 
> ReadOnlyMetastorage initialization, which in turn occur during 
> GridCacheDatabaseSharedManager start.
> We can split ReadOnlyMetastorage initialization and notification of listeners 
> - this will allow all components to subscribe for read-only metastorage ready 
> event.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to