[
https://issues.apache.org/jira/browse/IGNITE-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619301#comment-16619301
]
Taras Ledkov edited comment on IGNITE-7855 at 9/18/18 3:46 PM:
---------------------------------------------------------------
[~isapego], my comments:
# Please review my minor changes of the codestyle and typos;
# Please add javadoc for {{OdbcRequestHandler#extractBatchError}},
{{OdbcQuery#(read|write)Binary}} ;
# {{OdbcQuery#OdbcQuery(java.lang.String, java.lang.Object[])}} not used;
# Please fix typo: {{SqlLexer::IsDelimeter}}->{{SqlLexer::IsDelimiter}}.
# Looks like the lexer doesn't handle quotas inside a STRING constant, e.g.
{{'I''m, OK with it.'}}. I guess the test {{LexerTokens}} is invalid:
"{{string with 'string quotes' inside}}" must be expected for SQL string
{{"'string with ''string quotes'' inside'"}}. However, this functionality is
not used in current implementation. It is not major issue.
was (Author: tledkov-gridgain):
[~isapego], my comments:
# Please review my minor changes of the codestyle;
# Please add javadoc for {{OdbcRequestHandler#extractBatchError}},
{{OdbcQuery#(read|write)Binary}} ;
# {{OdbcQuery#OdbcQuery(java.lang.String, java.lang.Object[])}} not used;
# Please fix typo: {{SqlLexer::IsDelimeter}}->{{SqlLexer::IsDelimiter}}.
# Looks like the lexer doesn't handle quotas inside a STRING constant, e.g.
{{'I''m, OK with it.'}}. I guess the test {{LexerTokens}} is invalid:
"{{string with 'string quotes' inside}}" must be expected for SQL string
{{"'string with ''string quotes'' inside'"}}. However, this functionality is
not used in current implementation. It is not major issue.
> ODBC: Support streaming mode
> ----------------------------
>
> Key: IGNITE-7855
> URL: https://issues.apache.org/jira/browse/IGNITE-7855
> Project: Ignite
> Issue Type: New Feature
> Components: odbc
> Reporter: Vladimir Ozerov
> Assignee: Igor Sapego
> Priority: Major
> Fix For: 2.7
>
>
> We need to support streaming mode in the same way it is done for JDBC.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
