[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622135#comment-16622135
]
Ivan Bessonov commented on IGNITE-9549:
---------------------------------------
* User attributes in CommandHandler should probably be trimmed in line 1630,
just like it's done for cache names. Maybe also check empty attributes.
* "New add user attribute in result" javadoc in CacheArguments doesn't look
clear at all. Something like "Additional user attributes." for both methods
would be better. Please also don't skip dots at the end of sentences.
* CacheDistributionTaskResult, line 308, there's a chance that you'll have
several commas in a row if "userAttribute" is null for some reason.
* CacheResetLostPartitionsTaskResult, line 38, technically you could get NPE
here if I understand it correctly.
* "testCacheDistribution" test has non-intuitive asserts in the end, please
add some clarifying comments.
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> ---------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
> Reporter: Alexand Polyakov
> Assignee: Alexand Polyakov
> Priority: Major
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
