[
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622570#comment-16622570
]
Andrey Gura commented on IGNITE-9601:
-------------------------------------
[~andrey-kuznetsov] I've looked at your change and have the following comments:
* {{FsyncModeFileWriteAheadLogManager}} haы different logic in compare with
{{FileWriteAheadLogManager}}.
* Could you please add multi-threaded test for case of rollover type
{{NEXT_SEGMENT}}? Test must generate some load from thread pool and dedicated
thread must log record with {{NEXT_SEGMENT}} rollover type. After some time or
amount of {{log(rec, NEXT_SEGMENT)}} calls you can check WAL for the following
invariant: every rollover record must be the second record in the WAL segment
(the first record is {{HEADER_RECORD}}).
* Please, fix java doc description of
{{IgniteWriteAheadLogManager.log(WALRecord entry, RolloverType rolloverType)}}
method. Now it is just copy&paste version of {{log(rec)}} method.
> Write rollover WAL record as the last record in current segment
> ---------------------------------------------------------------
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
> Issue Type: Task
> Affects Versions: 2.6
> Reporter: Andrey Kuznetsov
> Assignee: Andrey Kuznetsov
> Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged.
> Moreover, the implementation allows data races, and rollover record is not
> necessarily the first record in the next segment. We are to add an option to
> logging facility to allow writing rollover record to the end of the current
> segment; subsequent records should get to the next segment then.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
