[
https://issues.apache.org/jira/browse/IGNITE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628378#comment-16628378
]
Vladimir Ozerov commented on IGNITE-8331:
-----------------------------------------
[~NIzhikov], [~PetrovMikhail],
SQL error codes are OK, as this is not public API. The main here is to ensure
that new codes are converted to SQLSTATE properly, which appears to be the
case. However, at the moment patch is not ready to be merged due to
insufficient test coverage. We need to extend existing tests to different cache
modes. From what I see currently we test only ATOMIC caches. But we also should
test TRANSACTIONAL, and what is more important TRANSACTIONAL_SNAPSHOT caches,
which use completely different DML execution flow. Also please make sure to add
tests for explicit transactions ("BEGIN TRANSACTION" -> DML -> "COMMIT") for
both positive and negative cases. We need to make sure that TX is rollled back
properly.
> SQL: Add Decimal precision and scale constraint
> -----------------------------------------------
>
> Key: IGNITE-8331
> URL: https://issues.apache.org/jira/browse/IGNITE-8331
> Project: Ignite
> Issue Type: Bug
> Reporter: Nikolay Izhikov
> Assignee: PetrovMikhail
> Priority: Major
> Labels: sql-engine
>
> We should support DECIMAL(X, Y) syntax.
> Currently, we ignore it.
> It affects semantics.
> E.g., one can insert a DECIMAL with greater precision into a cache/table
> without any problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
