[
https://issues.apache.org/jira/browse/IGNITE-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629008#comment-16629008
]
Anton Vinogradov commented on IGNITE-9532:
------------------------------------------
[~uday],
1) I see an incorrect comparison in the {{clear}} method.
Use {{obj instanceof BinaryObject}} check instead.
2) {{withKeepBinary}} should be implemented inside {{GridCacheQueueAdapter}}
{{GridCacheQueueProxy}}'s {{withKeepBinary}} should only control the {{gate}}.
3) It's incorrect to have such constructor {{new
CacheOperationContext(cctx.skipStore(), ...}} since {{cctx.skipStore()}} uses
{{opCtx}} and we know it's {{null}}.
{noformat}
CacheOperationContext opCtx = opCtxPerCall.get();
return (opCtx != null && opCtx.skipStore());
{noformat}
4) I like your idea of {{initQueue}} method,
but I see no reason to create 6 additional tests.
You can just create a queue with keepBinary because of some flag and run
existing tests twice (with keeping binary and without).
Easiest case to do this is to create special "binary" suite like
{{org.apache.ignite.testsuites.IgniteBinaryHibernate5TestSuite}}.
Please check Ignite's code to find a good way to do that. I'm pretty sure we
already have something similar.
> Binary mode for Ignite Queue
> ----------------------------
>
> Key: IGNITE-9532
> URL: https://issues.apache.org/jira/browse/IGNITE-9532
> Project: Ignite
> Issue Type: New Feature
> Components: binary, data structures
> Reporter: Uday Kale
> Assignee: Uday Kale
> Priority: Major
> Fix For: 2.8
>
>
> Add binary mode (withKeepBinary) to Data Structures Queue.
> This will allow retrieving values in binary format when needed or when class
> is not available, and will allow implementing the structures in other
> platforms (.NET, C++).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
